Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about em unit in the column width jsdoc #7443

Merged
merged 2 commits into from
May 24, 2024
Merged

docs: add note about em unit in the column width jsdoc #7443

merged 2 commits into from
May 24, 2024

Conversation

DiegoCardoso
Copy link
Contributor

Description

Add a new paragraph to mention the issue of using em length unit in columns width.

Part of vaadin/flow-components#6260

@DiegoCardoso DiegoCardoso requested a review from vursen May 24, 2024 08:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vursen
Copy link
Contributor

vursen commented May 24, 2024 •
edited
Loading

I've just noticed that the text on the docs website mentions an option of using the same font size for all the cells as an alternative to rem.

When length relative to the font size is needed, use instead the rem length unit -- or make sure that the font size is consistent across the cells.

I'm now thinking if it's important to mention this in the JSDoc too. What do you think?

@DiegoCardoso
Copy link
Contributor Author

I've just noticed that the text on the docs website mentions an option of using the same font size for all the cells as an alternative to rem.

When length relative to the font size is needed, use instead the rem length unit -- or make sure that the font size is consistent across the cells.

I'm now thinking if it's important to mention this in the JSDoc too. What do you think?

I tried to be a bit more concise on the JSDoc, so that's why I didn't add it here.

@DiegoCardoso DiegoCardoso merged commit 92540a8 into main May 24, 2024
9 checks passed
@DiegoCardoso DiegoCardoso deleted the docs/grid/column-width branch May 24, 2024 09:17
vaadin-bot pushed a commit that referenced this pull request May 24, 2024
@DiegoCardoso @vaadin-bot
docs: add note about em unit in the column width jsdoc (#7443)
d5436eb 
* docs: add note about `em` unit in the column `width` jsdoc

* docs: add mention to the type declaration
vaadin-bot pushed a commit that referenced this pull request May 24, 2024
@DiegoCardoso @vaadin-bot
docs: add note about em unit in the column width jsdoc (#7443)
864a461 
* docs: add note about `em` unit in the column `width` jsdoc

* docs: add mention to the type declaration
DiegoCardoso added a commit that referenced this pull request May 24, 2024
@vaadin-bot @DiegoCardoso
docs: add note about em unit in the column width jsdoc (#7443) (C…
0d0e84a 
…P: 24.4) (#7444)

* docs: add note about `em` unit in the column `width` jsdoc

* docs: add mention to the type declaration

Co-authored-by: Diego Cardoso <[email protected]>
web-padawan pushed a commit that referenced this pull request May 31, 2024
@vaadin-bot @DiegoCardoso
docs: add note about em unit in the column width jsdoc (#7443) (#…
976739a 
…7445)

Co-authored-by: Diego Cardoso <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.3 cherry-picked-24.4 prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.alpha1 target/24.3 target/24.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiegoCardoso @vursen @vaadin-bot